Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filestream] New Input package #2735

Merged
merged 8 commits into from
May 9, 2022
Merged

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Feb 23, 2022

What does this PR do?

This PR adds a custom input package for the filestream input, similar to how we have input packages for other similar custom inputs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@P1llus P1llus requested a review from kvch February 23, 2022 11:32
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@P1llus
Copy link
Member Author

P1llus commented Feb 23, 2022

While the package is now in a working state, there is still some work that needs to be done on the documentation side, especially:

  1. The README.md is currently just the same as from the filebeat documentation, do we want to update it or keep it?
  2. The description for UI options in manifest.yml can be quite long, they are also based on the documentation we already have for those fields.
  3. We need to make sure all the UI fields have the correct type (bool or text).

@P1llus
Copy link
Member Author

P1llus commented Feb 23, 2022

Working with @kvch to see what we can do on the documentation front. Maybe we could minimize the documentation in the UI, and link more to the documentation page?

@elasticmachine
Copy link

elasticmachine commented Feb 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-27T12:18:35.422+0000

  • Duration: 13 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@felixbarny felixbarny mentioned this pull request Apr 4, 2022
13 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.857
Classes 100.0% (0/0) 💚 2.857
Methods 100.0% (3/3) 💚 11.905
Lines 100.0% (0/0) 💚 11.167
Conditionals 100.0% (0/0) 💚

@P1llus P1llus requested review from a team and faec and removed request for a team April 27, 2022 14:39
@P1llus P1llus merged commit 3ca5459 into elastic:main May 9, 2022
@P1llus P1llus removed the request for review from faec May 9, 2022 11:28
@andrewkroh andrewkroh added the New Integration Issue or pull request for creating a new integration package. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Integration Issue or pull request for creating a new integration package. Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants