Tune docker package according to Beat's fields deprecation #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrsMark <[email protected]>
ChrsMark
added
the
Team:Cloudnative-Monitoring
Signed-off-by: ChrsMark <[email protected]>
mtojek
reviewed
Feb 23, 2022
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
mtojek
reviewed
Feb 23, 2022
packages/docker/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.3.0" | |||
There was a problem hiding this comment.
That would be a breaking change, so 2.0.0?
Signed-off-by: ChrsMark <[email protected]>
mtojek
approved these changes
Feb 23, 2022
packages/docker/changelog.yml
Outdated
| - version: "2.0.0" | ||
| changes: | ||
| - description: Remove deprecated fields | ||
| type: enhancement |
There was a problem hiding this comment.
nit: Maybe use the type: breaking-change
Signed-off-by: ChrsMark <[email protected]>
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tunes docker package accordingly to remove deprecated fields.
Related to elastic/beats#30413 elastic/beats#30500 elastic/beats#27933