-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add skeleton for integrations on Windows #1713
[CI] Add skeleton for integrations on Windows #1713
Conversation
b636a52
to
62b5b5a
Compare
62b5b5a
to
30610b4
Compare
…thub.com:v1v/integrations into feature/refactor-to-support-windows-integrations * 'feature/refactor-to-support-windows-integrations' of github.com:v1v/integrations: (200 commits) [CI] Draft for windows system tests [journald] Create custom journald input package (elastic#1739) [Microsoft_DHCP] New package replacing old RSA2ELK DHCP package (elastic#1793) Fix contains check for forwarded tag (elastic#1861) [google_workspace] Fix contains check for forwarded tag (elastic#1819) Fix contains check for forwarded tag (elastic#1805) Fix contains check for forwarded tag (elastic#1815) Fix contains check for forwarded tag (elastic#1816) Fix contains check for forwarded tag (elastic#1817) Fix contains check for forwarded tag (elastic#1818) Fix contains check for forwarded tag (elastic#1820) Fix contains check for forwarded tag (elastic#1821) Fix contains check for forwarded tag (elastic#1822) Fix contains check for forwarded tag (elastic#1823) Fix contains check for forwarded tag (elastic#1824) Fix contains check for forwarded tag (elastic#1825) Fix contains check for forwarded tag (elastic#1826) Fix contains check for forwarded tag (elastic#1827) Fix contains check for forwarded tag (elastic#1828) Fix contains check for forwarded tag (elastic#1829) ...
.ci/Jenkinsfile
Outdated
|
||
def runWindowsSystemTests(name) { | ||
return { | ||
def linuxIp = grabWorkerIP() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look for the ip in the current linux worker.
.ci/Jenkinsfile
Outdated
// TODO: run the stack that's needed | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prepare the context in the linux worker (services and so on)
.ci/Jenkinsfile
Outdated
def envContext = [] | ||
envContext.add("KIBANA_URL=https://${linuxIp}:5601") | ||
envContext.add("ELASTICSEARCH_URL=https://${linuxIp}:9200") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup the environment variables fro the services that run in the linux worker then the windows worker will consume them
.ci/Jenkinsfile
Outdated
// TOOD use the batch syntax in the pipelien and in the script | ||
sh(label: "Test integration: ${name}", script: ''' | ||
eval "$(../../build/elastic-package stack shellinit)" | ||
../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage | ||
''') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed to be changed to be Windows based
envContext.add("ELASTICSEARCH_URL=https://${linuxIp}:9200") | ||
|
||
withNode(labels: 'windows-2019 && docker && immutable', sleepMin: 10, sleepMax: 100) { | ||
withEnv(envContext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load the above defined environment variables that contain the IP of the linux worker
🌐 Coverage report
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
I'll close this PR, you can freely reopen it if this integration is something needed in the future |
What does this PR do?
Refactor pipeline to support windows integrations. It requires to implement
isIntegrationForWindows
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).Author's Checklist
How to test this PR locally
Related issues
Screenshots