Attach the registry image to a specific version #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds in the integrations repo should not change over time. Also development in the registry should not directly affect the integrations repo. To have things more reproducible, this changes the docker container which is run for the registry to a specific revision. It is the same revision which is uesd for the golang dependencies. If possible, these two should stay in sync in the future.
💚 Build Succeeded
Expand to view the summary
Build stats
|
mtojek
approved these changes
Jul 3, 2020
|
@mtojek AFAIK there are no such images for Kibana and ES. @kuisathaverat might know more? |
|
I think there are no incremental images for Kibana or Elasticsearch, you have the snapshots but are replaces every day. |
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
Builds in the integrations repo should not change over time. Also development in the registry should not directly affect the integrations repo. To have things more reproducible, this changes the docker container which is run for the registry to a specific revision. It is the same revision which is uesd for the golang dependencies. If possible, these two should stay in sync in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds in the integrations repo should not change over time. Also development in the registry should not directly affect the integrations repo. To have things more reproducible, this changes the docker container which is run for the registry to a specific revision. It is the same revision which is uesd for the golang dependencies. If possible, these two should stay in sync in the future.