-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus] add event.module and event.dataset #1249
Conversation
Add `module.event` and `module.dataset` to all data streams in prometheus package. From changes discussed in elastic/security-team#780
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to bump up kibana version constraint:
conditions:
kibana.version: "^7.14.0"
packages/prometheus/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "0.4.0" | |||
changes: | |||
- description: Set `module.event` and `module.dataset` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: event.module and event.dataset
nit: same in the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it, please!
What does this PR do?
Add
event.module
andevent.dataset
to all data streams in prometheus package.From changes discussed in https://github.com/elastic/security-team/issues/780
Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).I didn't run
elastic-package test
as I'm still setting up all the required environment.