[proofpoint_on_demand] - Added support for configurable retry options #12103
Conversation
ShourieG
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
ShourieG
added
integration
🚀 Benchmarks reportTo see the full report comment with |
| @@ -4,10 +4,19 @@ redact: | |||
| fields: ~ | |||
| program: | | |||
| bytes(state.response).decode_json().as(body,{ | |||
There was a problem hiding this comment.
This should work without the bytes conversion.
Come to think of it, this program is equivalent (in the happy path) to the (very much cheaper) {"events":{"message":string(state.response)}}. This will not find invalid JSON, but that will be caught in ingest. (/cc @andrewkroh)
However, I'm unclear why this is being changed here.
There was a problem hiding this comment.
@efd6, I missed this, will update. I was playing around with a couple of things but forgot to checkout.
There was a problem hiding this comment.
reverted those changes, did not make any other changes here since it's out of scope for this PR.
|
💚 Build Succeeded
History
cc @ShourieG |
| - name: min_wait_time | ||
| type: text | ||
| title: Minimum Wait Time | ||
| description: "The minimum amount of time the agent will wait before attempting to reconnect to the websocket endpoint if the connection is lost. \nThis is a time duration value. Examples, 1s, 1m, 1h.\n" |
There was a problem hiding this comment.
| description: "The minimum amount of time the agent will wait before attempting to reconnect to the websocket endpoint if the connection is lost. \nThis is a time duration value. Examples, 1s, 1m, 1h.\n" | |
| description: |- | |
| The minimum amount of time the agent will wait before attempting to reconnect to the websocket endpoint if the connection is lost. | |
| This is a time duration value. Examples, 1s, 1m, 1h. |
There was a problem hiding this comment.
Elastic package format auto formats this. I had it similarly to your suggestion initially. Since I run a combined command for build this always happens.
| - name: max_wait_time | ||
| type: text | ||
| title: Maximum Wait Time | ||
| description: "The maximum amount of time the agent will wait before attempting to reconnect to the websocket endpoint if the connection is lost. \nThis is a time duration value. Examples, 1s, 1m, 1h.\n" |
There was a problem hiding this comment.
| description: "The maximum amount of time the agent will wait before attempting to reconnect to the websocket endpoint if the connection is lost. \nThis is a time duration value. Examples, 1s, 1m, 1h.\n" | |
| description: |- | |
| The maximum amount of time the agent will wait before attempting to reconnect to the websocket endpoint if the connection is lost. | |
| This is a time duration value. Examples, 1s, 1m, 1h. |
|
Package proofpoint_on_demand - 1.2.0 containing this change is available at https://epr.elastic.co/package/proofpoint_on_demand/1.2.0/ |
Type of change
Proposed commit message
Added support for configurable retry options which was introduced in 8.16.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots