Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco_ios] Add support for ISO 8601 timestamps #11497

Merged
merged 2 commits into from
Oct 24, 2024
Merged

[cisco_ios] Add support for ISO 8601 timestamps #11497

merged 2 commits into from
Oct 24, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Oct 23, 2024 •
edited
Loading

Proposed commit message

  • Add support for ISO 8601 timestamps

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/cisco_ios
elastic-package test

Related issues

@taylor-swanson
[cisco_ios] Add support for ISO 8601 timestamps
a72b9dd 
- Add support for ISO 8601 timestamps
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Oct 23, 2024
@taylor-swanson taylor-swanson self-assigned this Oct 23, 2024
@taylor-swanson taylor-swanson marked this pull request as ready for review October 23, 2024 14:23
@taylor-swanson taylor-swanson requested a review from a team as a code owner October 23, 2024 14:23
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

cc @taylor-swanson

@taylor-swanson taylor-swanson merged commit 42826c8 into elastic:main Oct 24, 2024
5 checks passed
@taylor-swanson taylor-swanson deleted the enhance/cisco-ios-8601timestamp branch October 24, 2024 12:43
@elastic-vault-github-plugin-prod
Copy link

Package cisco_ios - 1.28.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwhyrock dwhyrock dwhyrock approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cisco_ios] Support ISO 8601 timestamps
3 participants
@taylor-swanson @elasticmachine @dwhyrock