Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloudflare] Add health check to mock service #11313

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Oct 2, 2024

Proposed commit message

[cloudflare] Add health check to mock service

Adds a health check to the mock service used in the `logpull` system
test. This will let docker check when the mock service is ready and
avoid starting the test too early.

The system test `interval` setting is lowered from `1h` to `2m`, which
may also help avoid test failures.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout added Integration:cloudflare Cloudflare bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Oct 2, 2024
@chrisberkhout chrisberkhout self-assigned this Oct 2, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner October 2, 2024 18:50
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. One query that needs to be decided.

packages/cloudflare/changelog.yml Outdated Show resolved Hide resolved
@chrisberkhout chrisberkhout enabled auto-merge (squash) October 4, 2024 06:19
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@chrisberkhout chrisberkhout merged commit 7f6e863 into main Oct 4, 2024
4 checks passed
@chrisberkhout chrisberkhout deleted the cloudflare-log-pull-mock-service-health-check branch October 4, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:cloudflare Cloudflare Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack 8.16.0-SNAPSHOT] [cloudflare] Failing test daily: system test: default in cloudflare.logpull
4 participants