Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ti_*: Add missing fields in transform destination indices (1) #10062

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Jun 4, 2024

Proposed commit message

Add missing fields for detection rules.

Some fields such as event.module were missing from the 
destination index. In few packages, the field mappings are getting 
overwritten when same prefix exists in multiple files. To prevent this, 
all fields with same prefix are moved into single file, ecs.yml. 
This is only a temporary fix until kibana.version is updated to 
>= 8.14.0, in which the root issue is fixed.

  - Add comments inside ecs.yml describing the issue.

  - Add `threat.feed.name` field only if its not added inside 
    ingest pipelines.

  - Some packages have missing fields `event.module` and `event.dataset` 
    which are added to both source and destination.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Manually verify destination mappings using system tests.

Following mappings validates that missing fields such as event.module are now mapped correctly in destination indices:
cif3-feed-source-8.13-1.13.1.json
cif3-feed-dest-8.13-1.13.1.json
crowdstrike-intel-dest-8.13-1.0.1.json
crowdstrike-intel-source-8.13-1.0.1.json
crowdstrike-ioc-dest-8.13-1.0.1.json
crowdstrike-ioc-source-8.13-1.0.1.json
cybersixgill-threat-dest-8.13-1.28.1.json
cybersixgill-threat-source-8.13-1.28.1.json
eclecticiq-threat-dest-8.13-1.0.1.json
eclecticiq-threat-source-8.13-1.0.1.json
maltiverse-indicator-dest-8.13-1.1.1.json
maltiverse-indicator-source-8.13-1.1.1.json
eset-apt-dest-8.13-1.1.1.json
eset-apt-source-8.13-1.1.1.json
eset-botnet-dest-8.13-1.1.1.json
eset-botnet-source-8.13-1.1.1.json
eset-cc-dest-8.13-1.1.1.json
eset-cc-source-8.13-1.1.1.json
eset-domains-dest-8.13-1.1.1.json
eset-domains-source-8.13-1.1.1.json
eset-files-dest-8.13-1.1.1.json
eset-files-source-8.13-1.1.1.json
eset-ip-dest-8.13-1.1.1.json
eset-ip-source-8.13-1.1.1.json
eset-url-dest-8.13-1.1.1.json
eset-url-source-8.13-1.1.1.json

Related issues

Screenshots

Before:
Screenshot 2024-06-04 at 7 12 51 PM

After:
Screenshot 2024-06-04 at 7 07 48 PM

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kcreddy kcreddy marked this pull request as ready for review June 4, 2024 13:44
@kcreddy kcreddy requested a review from a team as a code owner June 4, 2024 13:44
@kcreddy kcreddy self-assigned this Jun 4, 2024
@kcreddy kcreddy added bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Jun 4, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy requested a review from andrewkroh June 4, 2024 13:44
@kcreddy kcreddy changed the title ti_*: Add missing fields in transform destination indices. ti_*: Add missing fields in transform destination indices Jun 4, 2024
@kcreddy kcreddy changed the title ti_*: Add missing fields in transform destination indices ti_*: Add missing fields in transform destination indices (1) Jun 4, 2024
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

When I found elastic/kibana#175331 I unfortunately didn't think to check for other integrations with affected transforms.

@kcreddy kcreddy merged commit ea6f587 into elastic:main Jun 7, 2024
5 checks passed
@elasticmachine
Copy link

Package ti_cif3 - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=ti_cif3

@elasticmachine
Copy link

Package ti_crowdstrike - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=ti_crowdstrike

@elasticmachine
Copy link

Package ti_cybersixgill - 1.28.1 containing this change is available at https://epr.elastic.co/search?package=ti_cybersixgill

@elasticmachine
Copy link

Package ti_eclecticiq - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=ti_eclecticiq

@elasticmachine
Copy link

Package ti_eset - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=ti_eset

@elasticmachine
Copy link

Package ti_maltiverse - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=ti_maltiverse

@andrewkroh andrewkroh added Integration:ti_eclecticiq EclecticIQ Integration:ti_eset ESET Threat Intelligence Integration:ti_maltiverse Maltiverse Integration:ti_cif3 Collective Intelligence Framework v3 Integration:ti_crowdstrike CrowdStrike Falcon Intelligence labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:ti_cif3 Collective Intelligence Framework v3 Integration:ti_crowdstrike CrowdStrike Falcon Intelligence Integration:ti_cybersixgill Cybersixgill Integration:ti_eclecticiq EclecticIQ Integration:ti_eset ESET Threat Intelligence Integration:ti_maltiverse Maltiverse Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants