elastic/obs-infraobs-integrations: Address skipped validation SVR00004 (batch 2)

[shmsr]

Inline the visualizations in packages as "by values" panels using https://github.com/elastic/visualizations_integrations_tools.

Please find the list of packages that requires inlining viz in the description of this #8452. Also see #8423 where already 8 packages have inlined viz. Multiple packages were left out in this PR as support for inlining saved searches was not there when making the change but the required enhancement is merged to the inlining tool.

Please see "Tip" in the description to learn how to use this tool to make the change. Please make sure to create separate commits for separate packages.

Relates:

• elastic/obs-infraobs-integrations: Skipped validations during migration of packages to format_version: 3.0.0 (package-spec v3) #8452 (comment)
• elastic/obs-infraobs-integrations: Skipped validations during migration of packages to format_version: 3.0.0 (package-spec v3) #8452
• elastic/obs-infraobs-integrations: Address skipped validation SVR00004 #8423

[harnish-elastic]

Here is a list of packages (11 packages) that have SVR00004 with the kibana.version and will be covered in this sprint:

activemq == ^8.8.0
apache_tomcat == ^8.8.0
cassandra == ^8.8.0
kafka == ^8.8.0
microsoft_sqlserver == ^8.10.2
mongodb == ^8.8.0
mysql == ^8.8.2
nginx == ^8.8.0
postgresql == ^8.8.0
redis == ^8.10.2
system == ^8.10.2

[harnish-elastic]

I have installed node 16.14.2 (mentioned as pre-requisites) and ran the command KIBANA="<kibana connection string>" node inline.js <path to kibana folder> with stack 8.8.0 for activemq. The script has modified the dashboard and while doing stack up, I am facing the attached error in the dashboard!

activemq-eac72840-f916-11ec-9736-016ee09668f5.json

cc: @drewdaemon

[drewdaemon]

As mentioned outside this thread, support for inline saved searches wasn't added until Kibana 8.10 (PR).

[harnish-elastic]

As mentioned outside this thread, support for inline saved searches wasn't added until Kibana 8.10 (PR).

Thank you for the help @drewdaemon!

@lalit-satapathy Based on the inline saved searches that added after 8.10 Kibana, we need to bump the Kibana to at least 8.10 to fix validation SVR00004. Here is the list of packages that need strict bump up from 8.8.0 to 8.10.0! Also if we bump the Kibana from 8.8 to 8.10, Users won't get any new release in 8.8.0 for that package as well user must need to update stack to 8.10 if they want future release! Let me know your thoughts on this!

activemq == ^8.8.0
apache_tomcat == ^8.8.0
cassandra == ^8.8.0
kafka == ^8.8.0
mongodb == ^8.8.0
mysql == ^8.8.2
nginx == ^8.8.0
postgresql == ^8.8.0

[lalit-satapathy]

We need Kibana 8.10 for supporting pass-by-value in dashboard, in these packages? Is there something unique in these packages which require this PR fix?

We enabled the pass-by-value in host of other packages without stack upgrade right?

I am fine with these stack upgrades, if absolutely needed, as we did similar for Lens & TSDB.

CC: @tommyers-elastic

[drewdaemon]

As far as I understand, SVR00004 expresses a preference from the Fleet team for by-value panels.

All the panel types which are checked by that rule can be by-value prior to Kibana 8.10 with the exception of saved searches.

So, it seems to me that we could either

• convert all by-reference panels to by-value except saved searches (may already be done) and keep skipping SVR00004 for now
• convert all saved searches to by-value, bump the minimum Kibana version to 8.10 and unskip SVR00004

Just depends on the priority of making those saved searches by-value vs continuing to support 8.8 and 8.9.

[tommyers-elastic]

i would vote to keep saved searches by reference and avoid bumping stack version. it's a bit annoying though that we have to keep skipping the rule which means we don't get alerted if we added a new by-ref visualisation in the future.

[drewdaemon]

Could always propose a change to package-spec so that SVR00004 only checks saved searches if the stack version is 8.10 or greater.

[lalit-satapathy]

i would vote to keep saved searches by reference and avoid bumping stack version. it's a bit annoying though that we have to keep skipping the rule which means we don't get alerted if we added a new by-ref visualisation in the future.

I agree to not bump the version unless we are already at a stack version >= 8.10.

For the remaining ones, we still need to skip SVR00004? is that correct.

[harnish-elastic]

i would vote to keep saved searches by reference and avoid bumping stack version. it's a bit annoying though that we have to keep skipping the rule which means we don't get alerted if we added a new by-ref visualisation in the future.

I agree to not bump the version unless we are already at a stack version >= 8.10.

For the remaining ones, we still need to skip SVR00004? is that correct.

@lalit-satapathy, I have raised a separate PR for fix validation SVR00004 whose Kibana is already > 8.10 (redis, system and microsoft_sqlserver)

For the remaining 8 packages, I have converted the PR to draft.

cc: @tommyers-elastic

[lalit-satapathy]

@harnish-elastic, @shmsr,

What is the next step plan for closing this issue?

[harnish-elastic]

@harnish-elastic, @shmsr,

What is the next step plan for closing this issue?

SVR00004 validation is for the following list is already addressed as per this task. #9323

activemq
apache_tomcat
cassandra
kafka
mongodb
mysql
nginx
postgresql

@shmsr We can close this issue.

[shmsr]

Thanks @harnish-elastic 🙌🏽