Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update processor-add_kubernetes_metadata.asciidoc #698

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Nov 20, 2023

Update description for add_resource_metadata based on the elastic/beats#36879 and the release notes since 8.11 https://www.elastic.co/guide/en/beats/libbeat/current/release-notes-8.11.0.html

Copy link
Contributor

mergify bot commented Nov 20, 2023

This pull request does not have a backport label. Could you fix it @gizas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gizas
Copy link
Contributor Author

gizas commented Nov 20, 2023

@kilfoyle seems that I dont have write access. Did something changed?

@kilfoyle
Copy link
Contributor

@gizas I know the docs repos have been updated to tighten the security a bit. By "write access" do you mean you're unable to merge the PR? It shows as green for me so I'm happy to merge it.

CC @bmorelli25 just in case I'm missing something about the repo permissions.

@gizas
Copy link
Contributor Author

gizas commented Nov 21, 2023

@kilfoyle indeed I dont have access to merge the PR
See image below:

Screenshot 2023-11-21 at 9 46 24 AM

Please if you can merge it? Thank you very much

@kilfoyle kilfoyle merged commit d52941a into elastic:main Nov 21, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants