Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install-layout.asciidoc to reflect logging changes introduced in 8.6.0 #631

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

rseldner
Copy link
Contributor

Updated widget to reflect the logging changes introduced in 8.6.0 (v2 architecture) to close this issue: #175

  1. switched agent log file from elastic-agent-json.log to elastic-agent.ndjson
  2. with the exception of Endpoint, beats/component logs are written to elastic-agent.ndjson rather than their own log file.

I believe the logging changes were introduces in the v2 architecture:
elastic/elastic-agent#1701

Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue: 
#175

Related changes:
elastic/elastic-agent#1701
@rseldner rseldner requested a review from blakerouse October 30, 2023 18:37
@rseldner rseldner added the documentation Improvements or additions to documentation label Oct 30, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

This pull request does not have a backport label. Could you fix it @rseldner? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@rseldner
Copy link
Contributor Author

I think this should be backported as far as 8.6 but not seeing a label for that version.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor suggestions to use the "Beats" attribute/variable.

As for backporting, our general policy is to backport only into active releases (the ones shown in the docs release dropdown).

Screenshot 2023-10-30 at 4 50 26 PM

Copy link
Contributor

mergify bot commented Nov 7, 2023

This pull request is now in conflict. Could you fix it @rseldner? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch <remote-repo>
git checkout -b rseldner-patch-1 <remote-repo>/rseldner-patch-1
git merge <remote-repo>/main
git push <remote-repo> rseldner-patch-1

@rseldner
Copy link
Contributor Author

Hi @kilfoyle this resulted in conflicts because it was not merged in time. I believe I resolved the conflicts. Can you take a look?

@kilfoyle
Copy link
Contributor

Hi @rseldner. Looks good! I just applied my suggestions so that we use the {beats} variable rather than the literal "beats". Assuming the CI checks pass, I'll merge this today. Thanks for adding this docs fix!

@kilfoyle kilfoyle merged commit 4fd3a33 into main Nov 14, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 14, 2023
…in 8.6.0 (#631)

* Update install-layout.asciidoc

Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue:
#175

Related changes:
elastic/elastic-agent#1701

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit 4fd3a33)
@kilfoyle
Copy link
Contributor

By the way, I should explain this a bit better:

As for backporting, our general policy is to backport only into active releases (the ones shown in the docs release dropdown).

We avoid pushing docs changes into releases that are no longer active because it can create an expectation that all changes are handled this way (and often we're unable to push changes into certain releases). Rather than create inconsistency, we try to stick to a policy of updating only the "active" branches. Just wanted to add some clarity about that. :-)

kilfoyle pushed a commit that referenced this pull request Nov 14, 2023
…in 8.6.0 (#631) (#683)

* Update install-layout.asciidoc

Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue:
#175

Related changes:
elastic/elastic-agent#1701

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

---------

Co-authored-by: David Kilfoyle <[email protected]>
(cherry picked from commit 4fd3a33)

Co-authored-by: Roberto Seldner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-request backport backport-8.11 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants