Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] Explicitly set the targetPort to the defined http port #134

Merged
merged 1 commit into from
May 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions kibana/examples/default/test/goss.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ http:
http://localhost:5601/app/kibana:
status: 200
timeout: 2000

http://helm-kibana-default-kibana:5601/app/kibana:
status: 200
timeout: 2000
1 change: 1 addition & 0 deletions kibana/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ spec:
- port: {{ .Values.service.port }}
protocol: TCP
name: http
targetPort: {{ .Values.httpPort }}
selector:
app: {{ .Chart.Name }}
release: {{ .Release.Name | quote }}
3 changes: 3 additions & 0 deletions kibana/tests/kibana_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ def test_defaults():
assert s['ports'][0]['port'] == 5601
assert s['ports'][0]['name'] == 'http'
assert s['ports'][0]['protocol'] == 'TCP'
assert s['ports'][0]['targetPort'] == 5601

c = r['deployment'][name]['spec']['template']['spec']['containers'][0]
assert c['name'] == 'kibana'
Expand Down Expand Up @@ -73,6 +74,8 @@ def test_overriding_the_port():
c = r['deployment'][name]['spec']['template']['spec']['containers'][0]
assert c['ports'][0]['containerPort'] == 5602

assert r['service'][name]['spec']['ports'][0]['targetPort'] == 5602


def test_adding_image_pull_secrets():
config = '''
Expand Down