Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error checks and file handle closes #92

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Add missing error checks and file handle closes #92

merged 1 commit into from
Jan 10, 2018

Conversation

andrewkroh
Copy link
Member

While reviewing this code I noticed some missing EOF error checks in the bufio.Scanner usage as well as a few missing Close() calls on file handles.

@andrewkroh
Add missing error checks and file handle closes
cf85d25 
While reviewing this code I noticed some missing EOF error checks in the bufio.Scanner usage as well as a few missing Close() calls on file handles.
@exekias exekias merged commit 635767b into elastic:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewkroh @exekias