Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Mem.Used calculation #82

Merged
merged 3 commits into from
Nov 28, 2017
Merged

Conversation

EOIDC
Copy link

@EOIDC EOIDC commented Oct 31, 2017

I think this obviously must be fixed. directly cause system/memory metrics fetching incorrect

@ruflin ruflin added the review label Nov 26, 2017
@ruflin
Copy link

ruflin commented Nov 26, 2017

@monicasarbu @andrewkroh Could one of you have a look at this one?

@ruflin ruflin requested a review from andrewkroh November 26, 2017 22:38
Copy link

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add an entry to the CHANGELOG?

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It just needs a changelog entry.

@PChou PChou force-pushed the fix-memory-used-bug branch from bcbcabf to ffe7d2e Compare November 27, 2017 13:27
@EOIDC
Copy link
Author

EOIDC commented Nov 27, 2017

i try to add a changelog entry, please review

Copy link

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My commits should have fixed the most recent CHANGELOG conflicts. Now waiting for appveyor to go green.

@ruflin ruflin merged commit 96f2eb0 into elastic:master Nov 28, 2017
@ruflin
Copy link

ruflin commented Nov 28, 2017

@EOIDC Thanks a lot for your contribution. We now must update gosigar in beats to get this fix in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants