MINOR: trim environment variable values #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
changed the title
When working on elastic#78, I was hit by a test failing on linux (debian host) Our code is triming values so we need to adjust the test code to make sure we also trim values before doing the comparison. Example: ``` expected: "${debian_chroot:+($debian_chroot)}\\u@\\h:\\w\\$ " actual: "${debian_chroot:+($debian_chroot)}\\u@\\h:\\w\\$" ```
ph
force-pushed
the
fix/trim-environment-variable-when-comparing
branch
from
1b14560 to
b1515f2
Compare
andrewkroh
approved these changes
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #78, I was hit by a test failing on linux (debian host)
Our code is triming values so we need to adjust the test code to make
sure we also trim values before doing the comparison.
Example: