Improve error handling on darwin #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors were ignored in fairly dangerous places, which could result in infinite loops. Potential fix for elastic/beats#2747.
Current coverage is 70.76% (diff: 11.11%)@@ master #47 diff @@
==========================================
Files 10 10
Lines 793 1081 +288
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 575 765 +190
- Misses 178 257 +79
- Partials 40 59 +19
|
|
LGTM |
ruflin
reviewed
Oct 11, 2016
| @@ -364,10 +364,16 @@ func kern_procargs(pid int, | |||
| if exe != nil { | |||
| exe(string(chop(path))) | |||
| } | |||
| if err != nil { | |||
There was a problem hiding this comment.
should this error check be even before the exe part?
There was a problem hiding this comment.
Yeah, would be better, I'll create another PR.
tsg
pushed a commit
to tsg/gosigar
that referenced
this pull request
Oct 11, 2016
Small follow up after elastic#47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors were ignored in fairly dangerous places, which could result
in infinite loops. Potential fix for elastic/beats#2747.