Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report cached data in Memory #145

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

fearful-symmetry
Copy link

See this issue for a tad more context: elastic/kibana#77517

Right now, most front-end components that try and graph cache usage is doing it incorrectly. We're grabbing cache as a fallback to actual memory, so we might as well just send it along so upstream components can use it.

Copy link

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@andresrc
Copy link

ping @elastic/integrations

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add a CHANGELOG entry.

@fearful-symmetry fearful-symmetry merged commit 53e981e into elastic:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants