Windows: Do not fail ProcState.Get when run by non-admin #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running under Windows as a non-administrator user, ProcState.Get() will fail with the error "OpenProcessToken failed for pid=XXX: Permission denied". This is a known issue under Windows: A non-admin won't be able to access the token of most processes, regardless of privileges (i.e. SeDebugPrivilege). We should still allow ProcState.Get to return with a missing username instead of failing completely.
ruflin
reviewed
May 27, 2019
ruflin
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under Windows as a non-administrator user, ProcState.Get() will fail with the error "OpenProcessToken failed for pid=XXX: Permission denied".
This is a known issue under Windows: A non-admin won't be able to access the token of most processes, regardless of privileges (i.e. SeDebugPrivilege).
This PR allows ProcState.Get to return with a missing username instead of failing completely.
I also took the opportunity to fix a case where it would be leaking a handle under an error condition.