-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable Debian 12 and bump llvm version to swift-5.6.3 #298
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
There are some errors with the LLVM for Debian 12:
https://root-forum.cern.ch/t/compiling-cling-error-numeric-limits-is-not-a-member-of-std/48812 swiftlang/llvm-project@5208ec5 contains the fix from https://github.com/apple/llvm-project/releases/tag/swift-5.6-RELEASE onwards. |
/test |
1 similar comment
/test |
(cherry picked from commit 1274d03)
…-5.6.3 (#301) Co-authored-by: Victor Martinez <[email protected]>
What
Does what it says in the tin.
Why
Debian 12
has been released early June 2023: https://www.debian.org/News/2023/20230610Issues
Requires debuerreotype/docker-debian-artifacts#196
Implementation details
Debian 12
is needed to be added in some of the Dockerfile templates so the packages are installed for that particular version. For such, I looked fordebian 11
and added the condition fordebian 12
llvm for
Debian 12
is also required, hence llvm-apple-mbp needs to be triggered too.llvm for
Debian 12
failed with some missing imports, see https://reviews.llvm.org/D89450 and #298 (comment), so it was required to bump the version for https://github.com/apple/llvm-project to swift-5.6.3-RELEASE.Once llvm-apple-mpb@PR-298 is finished, we could manually re-tag those docker images for
Debian 12
so it can be consumed accordingly.Otherwise
Then
And I re-triggered the MBP build for this PR.