Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add msitools to docker beats golang-crossbuild 1.17 main image #152

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add msitools to docker beats golang-crossbuild 1.17 main image #152

merged 2 commits into from
Jan 24, 2022

Conversation

aleksmaus
Copy link
Contributor

Need to be able to extract the a file from .MSI distro for osquerybeat.
The current workaround is installing msitools during osquerybeat build time for window platform.
Including this into the builder image would allow us to remove the workaround.

Closes: elastic/beats#29826

Screenshot verifying the local image build msiextract tool is installed with this change:
Screen Shot 2022-01-24 at 9 21 57 AM

@elasticmachine
Copy link

elasticmachine commented Jan 24, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-24T17:07:06.373+0000

  • Duration: 130 min 33 sec

  • Commit: 540a82b

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@v1v v1v requested a review from a team January 24, 2022 14:31
@aleksmaus aleksmaus requested a review from v1v January 24, 2022 14:33
@aleksmaus
Copy link
Contributor Author

/test

@v1v v1v added the enhancement New feature or request label Jan 24, 2022
@v1v v1v mentioned this pull request Jan 24, 2022
Merged
@aleksmaus
Copy link
Contributor Author

/test

kuisathaverat
kuisathaverat approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as the CI pass it can be merged

@aleksmaus
Copy link
Contributor Author

@v1v @kuisathaverat
I don't have write access to the repository, can't merge.

@v1v v1v merged commit cf7f375 into elastic:main Jan 24, 2022
v1v added a commit that referenced this pull request Feb 22, 2022
@v1v
Merge branch 'main' of github.com:elastic/golang-crossbuild into feat…
969d20e 
…ure/test-103

* 'main' of github.com:elastic/golang-crossbuild:
  [Automation] Update go release version to 1.17.7 (#154)
  Add msitools to docker beats golang-crossbuild 1.17 main image (#152)
  fix copy npcap (#149)
  Add Apache license 2 to the repository. (#151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@v1v v1v Awaiting requested review from v1v

Assignees

@aleksmaus aleksmaus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Osquerybeat: Need to be able to extract osqueryd.exe from osquery MSI package during windows package creation.
4 participants
@aleksmaus @elasticmachine @kuisathaverat @v1v