Fix failing type conversation #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some edge cases using environment variables or direct conversation including floating values have been shown to fail - add direct support for float conversation by identifying if target type is float + support casting int/uint to float - string type can be parsed/converted to types bool, int, uint and float. In few cases, strings for numberic values have been read from yaml and put into ucfg (e.g. user using quotes, environment variable expansion). Allowing to convert strings dynamically to primitives solves some failing edge cases (new unit tests included).
urso
force-pushed
the
fix/string-type-conv
branch
from
10cd3f1 to
8769aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some edge cases using environment variables or direct conversation
including floating values have been shown to fail
type is float + support casting int/uint to float
In few cases, strings for numberic values have been read from yaml and
put into ucfg (e.g. user using quotes, environment variable
expansion).
Allowing to convert strings dynamically to primitives solves some
failing edge cases (new unit tests included).
Resolves: #67, #68