Make README.md example compile #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
reviewed
Feb 27, 2019
README.md
Outdated
| @@ -63,20 +63,20 @@ type ExampleConfig struct { | |||
| // Defines default config option | |||
| var ( | |||
| defaultConfig = ExampleConfig{ | |||
| Counter: 4, | |||
| Counter: string(4), | |||
There was a problem hiding this comment.
better keep 4 here and change the type of counter to int. The validators on Counter are numeric validators and won't work on strings.
There was a problem hiding this comment.
I see, I updated the pull-request with counter type int
|
Thanks you! I left you a comment. Changing the |
|
@urso |
|
PR LGTM. Seems like the CLA webhook is not responding. Double checking with CLA DB I did find you have signed the CLA yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readme example wasn't compiling.