Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace github.com/joeshaw/multierror with errors.Join #216

Closed
andrewkroh opened this issue Apr 5, 2024 · 0 comments · Fixed by #217
Closed

Replace github.com/joeshaw/multierror with errors.Join #216

andrewkroh opened this issue Apr 5, 2024 · 0 comments · Fixed by #217
Labels
good first issue Good for newcomers

Comments

@andrewkroh
Copy link
Member

We could probably replace github.com/joeshaw/multierror with the stdlib https://pkg.go.dev/errors#Join (added in go1.20).
@andrewkroh andrewkroh added the good first issue Good for newcomers label Apr 5, 2024
andrewkroh added a commit to andrewkroh/go-sysinfo that referenced this issue Apr 5, 2024
@andrewkroh
Use errors.Join
cc1ba20 
Replace usages of github.com/joeshaw/multierror with errors.Join,
which was added to the stdlib in Go 1.20.

Closes elastic#216
@andrewkroh andrewkroh mentioned this issue Apr 5, 2024
Merged
andrewkroh added a commit to andrewkroh/go-sysinfo that referenced this issue Apr 5, 2024
@andrewkroh
Use errors.Join
0b615a4 
Replace usages of github.com/joeshaw/multierror with errors.Join,
which was added to the stdlib in Go 1.20.

Closes elastic#216
andrewkroh added a commit to andrewkroh/go-sysinfo that referenced this issue Apr 5, 2024
@andrewkroh
Use errors.Join
fd4ab6e 
Replace usages of github.com/joeshaw/multierror with errors.Join,
which was added to the stdlib in Go 1.20.

Closes elastic#216
andrewkroh added a commit that referenced this issue Apr 5, 2024
@andrewkroh
Use errors.Join (#217)
8885924 
Replace usages of github.com/joeshaw/multierror with `errors.Join`,
which was added to the stdlib in Go 1.20.

Closes #216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use errors.Join andrewkroh/go-sysinfo
1 participant
@andrewkroh