-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildkite introduction #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, left a request for adding the ingest-end-prod-team and updating the RRE definition
catalog-info.yaml
Outdated
lifecycle: production | ||
|
||
--- | ||
# yaml-language-server: $schema=https://gist.githubusercontent.com/elasticmachine/988b80dae436cafea07d9a4a460a011d/raw/e57ee3bed7a6f73077a3f55a38e76e40ec87a7cf/rre.schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually had a discussion with the ci-systems team about this (because it's pinned to a specific version and doesn't include the latest information for RRE) and we should instead be using:
we should also raise PRs to fix old occurrences.
internal reference https://elasticco.atlassian.net/browse/CI-322?focusedCommentId=96184
ingest-fp: | ||
access_level: MANAGE_BUILD_AND_READ | ||
everyone: | ||
access_level: READ_ONLY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's ensure that we always add the platform ingest eng prod team too like https://github.com/elastic/logstash/blob/8fa3bd0d7f4eed8f808120706a0f74ec5c1847a7/catalog-info.yaml#L265-L266
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
first PR for starting work with Buildkite