Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildkite introduction #42

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Buildkite introduction #42

merged 2 commits into from
Nov 20, 2023

Conversation

leo-ri
Copy link
Contributor

@leo-ri leo-ri commented Nov 17, 2023

first PR for starting work with Buildkite

@leo-ri leo-ri requested a review from a team as a code owner November 17, 2023 15:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T10:54:56.585+0000

  • Duration: 9 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 2858
Skipped 0
Total 2858

Copy link

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, left a request for adding the ingest-end-prod-team and updating the RRE definition

lifecycle: production

---
# yaml-language-server: $schema=https://gist.githubusercontent.com/elasticmachine/988b80dae436cafea07d9a4a460a011d/raw/e57ee3bed7a6f73077a3f55a38e76e40ec87a7cf/rre.schema.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually had a discussion with the ci-systems team about this (because it's pinned to a specific version and doesn't include the latest information for RRE) and we should instead be using:

https://gist.githubusercontent.com/elasticmachine/988b80dae436cafea07d9a4a460a011d/raw/rre.schema.json

we should also raise PRs to fix old occurrences.

internal reference https://elasticco.atlassian.net/browse/CI-322?focusedCommentId=96184

ingest-fp:
access_level: MANAGE_BUILD_AND_READ
everyone:
access_level: READ_ONLY

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leo-ri leo-ri requested a review from dliappis November 20, 2023 10:55
Copy link

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlind23 jlind23 merged commit f72886d into elastic:main Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants