-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in buildkite #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buildkite pipeline looks like it works as in Jenkins, good job! 👍
I was wondering if those lint
failures shown in Jenkins and Buildkite should be fixed in this PR.
set -euo pipefail | ||
|
||
go version | ||
make lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that both in Jenkins and Buldkite lint is showing some differences but it does not fail the step/stage in CI.
https://beats-ci.elastic.co/job/Library/job/go-licenser-mbp/job/PR-64/9/console
Should this make fail the output ?
Maybe adding this to the lint
target in the Makefile?
$ git diff
diff --git Makefile Makefile
index 4443308..2e946ad 100644
--- Makefile
+++ Makefile
@@ -61,6 +61,7 @@ install:
lint: build
@ go run honnef.co/go/tools/cmd/staticcheck@$(VERSION_STATICCHECK)
@ gofmt -d -e -s .
+ @ test -z $(shell gofmt -l main.go | tee /dev/stderr)
@ $(GOBIN)/go-licenser -d -exclude golden
.PHONY: format
If this change is introduced, some files would needed to be updated (main.go and main_test.go)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed over slack, we should keep that for a later PR. The linting step shouldn't be a blocker for now.
Migration Jenkins to Buildkite