Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in buildkite #64

Merged
merged 10 commits into from
Jun 7, 2023
Merged

Run tests in buildkite #64

merged 10 commits into from
Jun 7, 2023

Conversation

leo-ri
Copy link
Contributor

@leo-ri leo-ri commented Jun 5, 2023

Migration Jenkins to Buildkite

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-06T15:36:48.826+0000

  • Duration: 4 min 10 sec

@leo-ri leo-ri changed the title WIP test buildkite triggering Run tests in buildkite Jun 6, 2023
@leo-ri leo-ri marked this pull request as ready for review June 6, 2023 16:01
@leo-ri leo-ri requested a review from a team as a code owner June 6, 2023 16:01
@leo-ri leo-ri requested review from zenitraM and Z3r0Sum and removed request for a team June 6, 2023 16:01
@jlind23 jlind23 requested a review from mrodm June 6, 2023 16:06
Copy link

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buildkite pipeline looks like it works as in Jenkins, good job! 👍

I was wondering if those lint failures shown in Jenkins and Buildkite should be fixed in this PR.

set -euo pipefail

go version
make lint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that both in Jenkins and Buldkite lint is showing some differences but it does not fail the step/stage in CI.
https://beats-ci.elastic.co/job/Library/job/go-licenser-mbp/job/PR-64/9/console

Should this make fail the output ?

Maybe adding this to the lint target in the Makefile?

 $ git diff
diff --git Makefile Makefile
index 4443308..2e946ad 100644
--- Makefile
+++ Makefile
@@ -61,6 +61,7 @@ install:
 lint: build
        @ go run honnef.co/go/tools/cmd/staticcheck@$(VERSION_STATICCHECK)
        @ gofmt -d -e -s .
+       @ test -z $(shell gofmt -l main.go | tee /dev/stderr)
        @ $(GOBIN)/go-licenser -d -exclude golden
 
 .PHONY: format

If this change is introduced, some files would needed to be updated (main.go and main_test.go)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed over slack, we should keep that for a later PR. The linting step shouldn't be a blocker for now.

@jlind23 jlind23 merged commit 673a313 into elastic:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants