Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving the source from my private repo to Elastic's repo #1

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Moving the source from my private repo to Elastic's repo #1

merged 3 commits into from
Dec 10, 2019

Conversation

alexh97
Copy link
Contributor

@alexh97 alexh97 commented Dec 9, 2019 •
edited
Loading

@alexh97 alexh97 requested a review from leathekd December 9, 2019 21:58
leathekd
leathekd requested changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@leathekd leathekd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a few tiny doc tweaks.

project-assigner/README.md Outdated Show resolved Hide resolved
project-assigner/README.md Outdated Show resolved Hide resolved
@leathekd
Copy link
Contributor

leathekd commented Dec 9, 2019

I can't see the diff for the dist/index.js file- does that need to be rebuilt now that it's in a different repo?

alexh97
alexh97 commented Dec 9, 2019
View reviewed changes
Copy link
Contributor Author

@alexh97 alexh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I've built that locally so it should contain everything it needs to run the action.

leathekd
leathekd approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@leathekd leathekd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexh97 alexh97 merged commit 3a4afe6 into elastic:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leathekd leathekd leathekd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexh97 @leathekd