Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-version #436

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Jun 7, 2021

What does this PR do?

Update go version to 1.16.5

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #436 updated

  • Start Time: 2021-06-09T16:14:13.948+0000

  • Duration: 5 min 15 sec

  • Commit: 0295c61

Test stats 🧪

Test Results
Failed 0
Passed 178
Skipped 0
Total 178

Trends 🧪

Image of Build Times

Image of Tests

@michel-laterman
Copy link
Contributor Author

/test

@michel-laterman michel-laterman added enhancement New feature or request and removed dependency labels Jun 7, 2021
@urso
Copy link

urso commented Jun 8, 2021

Looks like the go.mod is incomplete?

@michel-laterman
Copy link
Contributor Author

I'm not really sure what's going on, I can recreate the issue locally but the steps that go says to take to resolve the issue (go mod download github.com/elastic/go-licenser go.elastic.co/go-licence-detector) do not fix it

@urso
Copy link

urso commented Jun 9, 2021

The recent problem was introduced with introducing go get .... When doing go get you update the dependency you get. In that case the go-licenser was updated. go get is run in the current working directory, which is contains the fleet-server source. This motivates the go tool to update your dependencies unfortunately. This might update go.sum and go.mod as well. The newer go-licenser version also changes the format it seems, resulting in the huge diff on the notice file.

@michel-laterman michel-laterman merged commit b382776 into elastic:master Jun 9, 2021
@michel-laterman michel-laterman deleted the go1.16.5 branch June 9, 2021 18:45
mergify bot pushed a commit that referenced this pull request Jun 9, 2021
Update go version

specify go mod download all as behaviour has changed.

(cherry picked from commit b382776)

# Conflicts:
#	Makefile
#	README.md
mergify bot added a commit that referenced this pull request Jun 9, 2021
* Update go-version (#436)

Update go version

specify go mod download all as behaviour has changed.

(cherry picked from commit b382776)

# Conflicts:
#	Makefile
#	README.md

* Fix merge conflicts

Co-authored-by: Michel Laterman <[email protected]>
Co-authored-by: michel-laterman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants