Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate checkin status to agent record #420

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

scunningham
Copy link

What does this PR do?

Writes out the checkin status field to the last_checkin_status field in the agent record. This is necessary to support UX changes.

Why is it important?

UX needs it.

Checklist

  • [x ] My code follows the style guidelines of this project
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] I have made corresponding change to the default configuration files
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Setup local fleet server and point an agent at it. You can validate field change using the dev tools in kibana.

Screenshots

Screen Shot 2021-06-02 at 3 40 57 PM

@scunningham scunningham added enhancement New feature or request v7.14.0 labels Jun 2, 2021
@scunningham scunningham requested review from jfsiii and aleksmaus June 2, 2021 19:47
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #420 updated

  • Start Time: 2021-06-02T20:56:41.053+0000

  • Duration: 4 min 19 sec

  • Commit: a97f374

Test stats 🧪

Test Results
Failed 0
Passed 178
Skipped 0
Total 178

Trends 🧪

Image of Build Times

Image of Tests

@jen-huang
Copy link

@ph / @urso This seems like a good candidate to backport to 7.13, what do you think?

@scunningham
Copy link
Author

I wouldn't backport unless we were backporting the new UX as well. Not sure we are buying ourselves much otherwise.

@jen-huang
Copy link

@scunningham We already have code in Fleet that looks at last_checkin_status from pre-Fleet Server days, not just for new UX, so this seems like a regression with agent status reporting that we didn't catch in testing.

Copy link

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks for getting this in so quickly. I ran this branch locally and, without any Kibana changes, it now shows an Unhealthy badge for an agent with last_checkin_status of degraded.

Screen Shot 2021-06-03 at 9 33 16 AM

Screen Shot 2021-06-03 at 9 33 28 AM

Without these changes, the UI marks the agents as Healthy

@ph
Copy link
Contributor

ph commented Jun 8, 2021

@scunningham based on the discussion from @jen-huang and the comment from @jfsiii I would backport this to 7.13.x too. If it's fine with you I will just add the label.

@scunningham
Copy link
Author

@ph I have no objection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v7.13.0 v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants