-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass namespaces to Fleet Server managed documents #3535
Conversation
We were initially planning to allow for changing an agent policy's space directly from Fleet UI, e.g. However, it's not clear if this is the direction we'll go. We may direct users to stack management instead, to avoid having multiple sources of truth for object/space management. When the space of an agent policy changes, though, we probably do need to dispatch an action to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
It's good that namespace is kept as an ES document detail and not added to the API that clients use.
Please add a changelog fragment as well
I think we probably can handle the whole namespace change directly from Kibana has we do when reassigning to a policy by updating the |
Quality Gate passedIssues Measures |
Description
Resolve #3505
Set the namespaces property in the different
.fleet-*
document managed by fleet server.Feature flag? do we need to release that feature under a feature flag, in my opinion if the namespaces are not populated in Kibana fleet server behavior do not change so it should be safe to release this without feature flag.
Test
I added a new integration test to cover the change
Todo
Questions