-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fake agent in fleet server standalone #2606
Conversation
How hard would it be to disable the coordinator completely? It does not serve any function right now and will actually incur costs for us due to extra refreshes and the associated API calls on stateless. |
Yes it's probably a better solution long term to remove the coordinator, @michel-laterman we do not have plan to use it? I remember you talking about maybe using this for remote ES output |
note that tests are failing due to an issue with the docker v24.0.0 release |
I don't think we'll need the coordinator for remote outputs, we've decided to revoke an agent's remote output key on checkin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this change to unblock testing, but we should open an issue that is prioritized in the near-future to remove the coordinator.
Have we tested to make sure that the it still grabs the ID that an agent generates if it's running under an agent? |
@michel-laterman Improving the unit test and also going to manually test the Agent case right now, but I want to understand more your concern. How would this change be an issue if it's only called when Fleet Server is not in agent mode? |
Description
Resolve #2605
This create a fake agent id and version for fleet server standalone to allow the coordinator to work.
How to test?
Run a standalone Fleet server and verify that you can enroll an agent and the agent is fully functional (get the policy ...)