Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fake agent in fleet server standalone #2606

Merged
merged 5 commits into from
May 24, 2023
Merged

Conversation

nchaulet
Copy link
Member

Description

Resolve #2605

This create a fake agent id and version for fleet server standalone to allow the coordinator to work.

How to test?

Run a standalone Fleet server and verify that you can enroll an agent and the agent is fully functional (get the policy ...)

@nchaulet nchaulet added the Team:Fleet Label for the Fleet team label May 18, 2023
@nchaulet nchaulet requested a review from a team as a code owner May 18, 2023 12:34
@nchaulet nchaulet self-assigned this May 18, 2023
@nchaulet nchaulet requested a review from a team as a code owner May 18, 2023 12:34
@nchaulet nchaulet requested review from michalpristas and pchila May 18, 2023 12:34
@elasticmachine
Copy link
Contributor

elasticmachine commented May 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-24T12:48:36.270+0000

  • Duration: 26 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 277
Skipped 1
Total 278

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@joshdover
Copy link
Contributor

joshdover commented May 18, 2023

How hard would it be to disable the coordinator completely? It does not serve any function right now and will actually incur costs for us due to extra refreshes and the associated API calls on stateless.

@nchaulet
Copy link
Member Author

How hard would it be to disable the coordinator completely? It does serve any function right now and will actually incur costs for us due to extra refreshes and the associated API calls on stateless.

Yes it's probably a better solution long term to remove the coordinator, @michel-laterman we do not have plan to use it? I remember you talking about maybe using this for remote ES output

@michel-laterman
Copy link
Contributor

note that tests are failing due to an issue with the docker v24.0.0 release

@michel-laterman
Copy link
Contributor

I don't think we'll need the coordinator for remote outputs, we've decided to revoke an agent's remote output key on checkin.

joshdover
joshdover previously approved these changes May 22, 2023
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change to unblock testing, but we should open an issue that is prioritized in the near-future to remove the coordinator.

@joshdover joshdover dismissed their stale review May 23, 2023 15:13

Needs tests

@joshdover joshdover self-assigned this May 23, 2023
@michel-laterman
Copy link
Contributor

Have we tested to make sure that the it still grabs the ID that an agent generates if it's running under an agent?

@joshdover joshdover disabled auto-merge May 23, 2023 16:52
@joshdover
Copy link
Contributor

joshdover commented May 24, 2023

Have we tested to make sure that the it still grabs the ID that an agent generates if it's running under an agent?

@michel-laterman Improving the unit test and also going to manually test the Agent case right now, but I want to understand more your concern. How would this change be an issue if it's only called when Fleet Server is not in agent mode?

@joshdover joshdover enabled auto-merge (squash) May 24, 2023 12:48
@joshdover joshdover merged commit 2091f86 into main May 24, 2023
@joshdover joshdover deleted the standalone-fake-agent branch May 24, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project:Serverless Team:Fleet Label for the Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Fleet server standalone coordination is not working
4 participants