Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added back agent team as codeowners #2117

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Added back agent team as codeowners #2117

merged 2 commits into from
Nov 29, 2022

Conversation

juliaElastic
Copy link
Contributor

Added back agent team as codeowners too with backport labels.

@juliaElastic juliaElastic added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify labels Nov 24, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner November 24, 2022 07:29
@juliaElastic juliaElastic self-assigned this Nov 24, 2022
@juliaElastic juliaElastic mentioned this pull request Nov 24, 2022
Closed
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 24, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-29T08:41:37.204+0000

  • Duration: 12 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 393
Skipped 1
Total 394

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@juliaElastic
Copy link
Contributor Author

How do I fix this error?

[2022-11-24T07:33:36.538Z] go: error loading go 1.16 module graph: github.com/elastic/elastic-agent-client/[email protected] requires
[2022-11-24T07:33:36.538Z] 	github.com/elastic/[email protected]: invalid version: unknown revision 5f1e54f40d3e
[2022-11-24T07:33:36.538Z] 
[2022-11-24T07:33:36.538Z] If reproducibility with go 1.16 is not needed:
[2022-11-24T07:33:36.538Z] 	go mod tidy -compat=1.17
[2022-11-24T07:33:36.538Z] For other options, see:
[2022-11-24T07:33:36.538Z] 	https://golang.org/doc/modules/pruning
[2022-11-24T07:33:36.538Z] Makefile:97: recipe for target 'notice' failed
[2022-11-24T07:33:36.538Z] make[1]: *** [notice] Error 1
[2022-11-24T07:33:36.538Z] make[1]: Leaving directory '/var/lib/jenkins/workspace/_server_fleet-server-mbp_PR-2117/src/github.com/elastic/fleet-server'
[2022-11-24T07:33:36.538Z] Makefile:74: recipe for target 'check-ci' failed
[2022-11-24T07:33:36.538Z] make: *** [check-ci] Error 2

@juliaElastic juliaElastic requested review from michel-laterman, a team and blakerouse and removed request for a team November 24, 2022 14:10
@juliaElastic
Copy link
Contributor Author

Jenkins, test this please

@juliaElastic
Copy link
Contributor Author

/test

@michel-laterman
Copy link
Contributor

@juliaElastic, it looks like the go mod issue are caused by a bad commit with the elastic-agent client: elastic/elastic-agent-client#48
updating the client version should fix it

@michel-laterman
Copy link
Contributor

I've created a PR that update dependencies to the latest patch version: #2126

@juliaElastic juliaElastic merged commit 211b19f into elastic:main Nov 29, 2022
@mergify mergify bot mentioned this pull request Nov 29, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 29, 2022
@juliaElastic @mergify
added back agent team as codeowners too (#2117)
13ba39e 
(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS
@mergify mergify bot mentioned this pull request Nov 29, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 29, 2022
@juliaElastic @mergify
added back agent team as codeowners too (#2117)
999efb3 
(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS
mergify bot pushed a commit that referenced this pull request Nov 29, 2022
@juliaElastic @mergify
added back agent team as codeowners too (#2117)
f1e588d 
(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS
This was referenced Nov 29, 2022
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 29, 2022
@juliaElastic @mergify
added back agent team as codeowners too (#2117)
40f0a5b 
(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS
juliaElastic added a commit that referenced this pull request Nov 29, 2022
@mergify @juliaElastic
[7.17](backport #2117) Added back agent team as codeowners (#2131)
4b18cd5 
* added back agent team as codeowners too (#2117)

(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS

* Update CODEOWNERS

Co-authored-by: Julia Bardi <[email protected]>
juliaElastic added a commit that referenced this pull request Nov 29, 2022
@mergify @juliaElastic
[8.4](backport #2117) Added back agent team as codeowners (#2132)
c52d86c 
* added back agent team as codeowners too (#2117)

(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS

* Update CODEOWNERS

Co-authored-by: Julia Bardi <[email protected]>
juliaElastic added a commit that referenced this pull request Nov 29, 2022
@mergify @juliaElastic
[8.5](backport #2117) Added back agent team as codeowners (#2133)
5a178c9 
* added back agent team as codeowners too (#2117)

(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS

* Update CODEOWNERS

Co-authored-by: Julia Bardi <[email protected]>
juliaElastic added a commit that referenced this pull request Nov 30, 2022
@mergify @juliaElastic
[8.6](backport #2117) Added back agent team as codeowners (#2134)
25c4b71 
* added back agent team as codeowners too (#2117)

(cherry picked from commit 211b19f)

# Conflicts:
#	.github/CODEOWNERS

* Update CODEOWNERS

Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@michel-laterman michel-laterman Awaiting requested review from michel-laterman

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@juliaElastic juliaElastic

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify backport-v8.5.0 Automated backport with mergify backport-v8.6.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliaElastic @elasticmachine @michel-laterman @cmacknz