Page responsive fix #998
Merged
Page responsive fix #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this |
added 3 commits
July 11, 2018 17:00
moved PageTitle inside of PageBody.
cchaos
force-pushed
the
page-responsive-fix
branch
from
fa0df32
to
f92133f
Compare
|
I also checked with Cloud, and they only use part of the Page components in a couple places, so it shouldn't be too much of chore to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR not only fixes the layout on small screens of
EuiPageand it's sub components, but also shifts where the sidebar lives. @snide and I talked it over and most of our designs have gone this way and it makes the most sense to keep the page header away from the sidebar.Before (moving sidebar)
After (moving sidebar)
And it still works with centered content
Before (responsive)
After (responsive)
The non-existent padding around the sidebar is on purpose so that the toggle button would expand the whole width.
I checked Kibana master to make sure it wouldn't break too many layouts and, at least in master, no one has used the
EuiPageHeaderorEuiPageSidebar, so no current layouts should break. The only place it is used is in the plugin generator, but that's a quick fix.