Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCard] Fix bug where footer were not getting aligned to the bottom #6424

Merged
merged 2 commits into from
Nov 22, 2022
Merged

[EuiCard] Fix bug where footer were not getting aligned to the bottom #6424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e93e7b
[EuiCard] Fix bug where footer were not getting aligned to the bottom
elizabetdev Nov 22, 2022
297522f
Adding CL
elizabetdev Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/card/card.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ export const euiCardStyles = (
euiCard__main: css`
display: flex;
inline-size: 100%;
flex-grow: 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot tested layout in four evergreen browsers on MacOS Monterey. All cards are lining up as expected now per the screenshot in PR description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking @1Copenut. 👍🏽

`,
layout: {
vertical: css`
Expand Down
3 changes: 3 additions & 0 deletions upcoming_changelogs/6424.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fix bug in `EuiCard` where footer were not aligned to the bottom of the card