-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiForm] specify default fullWidth with root component #6229
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
564e188
[EuiForm] specify default fullWidth with root component
f538077
[docs] mention ability to specify fullWidth on EuiForm in the full wi…
e590265
remove unnecessary text
7376450
update changelog verbiage
50b8c8d
Merge branch 'main' of https://github.com/elastic/eui into implement/…
fa97aa7
define default values for docs which can't be determined by react-vie…
251ab99
Merge branch 'main' of github.com:elastic/eui into implement/form-lay…
53950f9
add dedicated docs example for fullWidth via context
301afc4
expand and customize the example a bit more
bca771e
remove snapshot test, just validate fullWidth class exists
1dafc38
Merge branch 'main' of https://github.com/elastic/eui into implement/…
303968c
add example of fullWidth being disabled in context
814de11
[PR feedback] Docs sentence casing
constancecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
src-docs/src/views/form_layouts/full_width_via_context.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
import React from 'react'; | ||
|
||
import { | ||
EuiForm, | ||
EuiFieldSearch, | ||
EuiRange, | ||
EuiTextArea, | ||
EuiFormRow, | ||
EuiFlexGroup, | ||
EuiFlexItem, | ||
EuiSpacer, | ||
EuiDescribedFormGroup, | ||
EuiSelect, | ||
EuiFilePicker, | ||
EuiButton, | ||
} from '../../../../src/components'; | ||
|
||
export default () => { | ||
const [range, setRange] = React.useState(42); | ||
|
||
return ( | ||
<EuiForm | ||
fullWidth | ||
onSubmit={(e) => { | ||
e.preventDefault(); | ||
}} | ||
> | ||
<EuiFlexGroup> | ||
<EuiFlexItem> | ||
<EuiFieldSearch | ||
placeholder="Search..." | ||
aria-label="An example of search with fullWidth" | ||
/> | ||
</EuiFlexItem> | ||
<EuiFlexItem grow={false}> | ||
<EuiButton>Search</EuiButton> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
|
||
<EuiSpacer size="l" /> | ||
|
||
<EuiFormRow | ||
label="Works on form rows too" | ||
helpText="Note that the fullWidth prop is not passed to any of these elements, it's read from the parent <EuiForm> component." | ||
> | ||
<EuiRange | ||
min={0} | ||
max={100} | ||
name="range" | ||
value={range} | ||
onChange={(e) => { | ||
if (e.target instanceof HTMLInputElement) { | ||
setRange(Number.parseInt(e.target.value, 10)); | ||
} | ||
}} | ||
/> | ||
</EuiFormRow> | ||
|
||
<EuiSpacer /> | ||
|
||
<EuiDescribedFormGroup | ||
title={<h3>Works with all form controls and layout components</h3>} | ||
description={ | ||
<> | ||
<p> | ||
Any component that supports the <code>fullWidth</code> prop that | ||
is. | ||
</p> | ||
<p> | ||
Make sure it is appropriate at all of the widths that the | ||
container can take. There are many situations where a full-width | ||
form is inappropriate. | ||
</p> | ||
</> | ||
} | ||
> | ||
<EuiFormRow label="Text area"> | ||
<EuiTextArea placeholder="" /> | ||
</EuiFormRow> | ||
</EuiDescribedFormGroup> | ||
|
||
<EuiFormRow label="Works on EuiSelect"> | ||
<EuiSelect | ||
options={[ | ||
{ | ||
value: 'option_one', | ||
text: | ||
'Option one is very long in order to try justifying the use of fullWidth on a select box', | ||
}, | ||
{ value: 'option_two', text: 'Option two' }, | ||
{ value: 'option_three', text: 'Option three' }, | ||
]} | ||
/> | ||
</EuiFormRow> | ||
|
||
<EuiFormRow label="It can be disabled for a specific control"> | ||
<EuiFilePicker display="default" fullWidth={false} /> | ||
</EuiFormRow> | ||
</EuiForm> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import React from 'react'; | ||
|
||
export interface FormContextValue { | ||
defaultFullWidth: boolean; | ||
} | ||
|
||
export const FormContext = React.createContext<FormContextValue>({ | ||
defaultFullWidth: false, | ||
}); | ||
|
||
export function useFormContext() { | ||
return React.useContext(FormContext); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... one downside about pulling defaults out of context is that
react-view
can't automatically determine default values anymore, so I've included them explicitly with@default
JSDoc tags... not sure this is going to be great, but I do think that the props on components could use better docs in general so maybe it wouldn't be bad to implement more@default
tags across the board...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super awesome workaround/find on this! Totally agreed we could stand to use more
@default
doc tags for instances where either typescript or react can't infer them automatically 🙌