Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving EuiBreadcrumb styles to Emotion. #5934

Merged
merged 25 commits into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
62a1154
Moving EuiBreadcrumb styles to Emotion.
1Copenut May 24, 2022
6fd7844
Tactfully merging main and picking work up again.
1Copenut Jul 13, 2022
668ddb5
Adding EUIHeaderBreadcrumb styles.
1Copenut Jul 13, 2022
53c6ca2
Apply suggestions from code review
constancecchen Jul 20, 2022
4424580
Fix Prettier complaints from GitHub suggestions
cee-chen Jul 20, 2022
8d07aa0
[PR feedback] Rename `headerBreadcrumb` to use boolean var naming
cee-chen Jul 20, 2022
4f24e55
Split out internal EuiBreadcrumb & EuiBreadcrumbContent components
cee-chen Jul 20, 2022
9cc29e2
Simplify text truncation CSS
cee-chen Jul 20, 2022
347725a
Remove unnecessary repeated font-weight declarations
cee-chen Jul 20, 2022
a455722
Simplify and clean up nested .euiBreadcrumb styles
cee-chen Jul 20, 2022
8aa914e
Refactor `EuiBreadcrumbCollapsed` into separate component
cee-chen Jul 21, 2022
e50a5f9
Remove `inPopover` CSS/nesting
cee-chen Jul 21, 2022
89be267
Misc EuiBreadcrumbs CSS cleanup
cee-chen Jul 21, 2022
bfb5e9b
Fix EuiControlBar Sass styling
cee-chen Jul 21, 2022
a267e5e
Refactor responsive detection/calculation logic to separate util
cee-chen Jul 21, 2022
63d7bdd
Refactor & optimize limitBreadcrumbs
cee-chen Jul 21, 2022
6051809
[PR feedback] Hide new header styling and nested/popover props from docs
cee-chen Jul 22, 2022
a686260
[PR feedback] Change internal `isInEuiHeader` prop to an exposed `typ…
cee-chen Jul 25, 2022
734690e
Refactor out last internal prop to more descriptive flag
cee-chen Jul 25, 2022
92d71fb
Fix the "Truncate each breadcrumb" example not matching production
cee-chen Jul 25, 2022
9b5687f
Merge branch 'main' into feature/tpierce-breadcrumbs-emotion
cee-chen Jul 25, 2022
58ecfea
Merging main to handle breadcrumbs.tsx conflict.
1Copenut Jul 28, 2022
5d3de7e
Fix useCurrentEuiBreakpoint refactor lost in merge conflict
cee-chen Jul 28, 2022
0d01636
Remove deleted Sass variables from JSON files and document in changelog
cee-chen Jul 28, 2022
9a90af4
woops 1 more smol thing
cee-chen Jul 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src-docs/src/views/breadcrumbs/breadcrumbs_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { Link } from 'react-router-dom';

import { GuideSectionTypes } from '../../components';

import { EuiCode, EuiBreadcrumbs, EuiText } from '../../../../src/components';
import { BreadcrumbResponsiveMaxCount, BreadcrumbProps } from './props';
import { EuiBreadcrumbs, EuiCode, EuiText } from '../../../../src/components';
import { BreadcrumbProps, BreadcrumbResponsiveMaxCount } from './props';

import { breadcrumbsConfig } from './playground';

Expand All @@ -28,7 +28,7 @@ const maxSource = require('!!raw-loader!./max');
import Color from './color';
const colorSource = require('!!raw-loader!./color');

const breadcrumpProps = {
const props = {
EuiBreadcrumbs,
EuiBreadcrumb: BreadcrumbProps,
EuiBreadcrumbResponsiveMaxCount: BreadcrumbResponsiveMaxCount,
Expand Down Expand Up @@ -84,7 +84,7 @@ export const BreadcrumbsExample = {
/>
</>
),
props: breadcrumpProps,
props,
playground: breadcrumbsConfig,
snippet: `<EuiBreadcrumbs
breadcrumbs={[
Expand Down Expand Up @@ -118,13 +118,13 @@ export const BreadcrumbsExample = {
<>
<p>
Use the <EuiCode>max</EuiCode> prop to collapse breadcrumbs beyond a
certain number. The center breadcrumbs will collpase into a single
certain number. The center breadcrumbs will collapse into a single
item allowing the user to navigate these items from within a
popover.
</p>
</>
),
props: breadcrumpProps,
props,
snippet: `<EuiBreadcrumbs
max={4}
breadcrumbs={breadcrumbs}
Expand All @@ -149,7 +149,7 @@ export const BreadcrumbsExample = {
</p>
</>
),
props: breadcrumpProps,
props,
demo: <Truncate />,
snippet: [
`<EuiBreadcrumbs
Expand All @@ -174,7 +174,7 @@ export const BreadcrumbsExample = {
</p>
</>
),
props: breadcrumpProps,
props,
demo: <TruncateSingle />,
snippet: [
`<EuiBreadcrumbs
Expand Down Expand Up @@ -206,7 +206,7 @@ export const BreadcrumbsExample = {
</p>
</>
),
props: breadcrumpProps,
props,
snippet: [
`<EuiBreadcrumbs
responsive={false}
Expand All @@ -231,7 +231,7 @@ export const BreadcrumbsExample = {
</p>
</>
),
props: breadcrumpProps,
props,
snippet: [
`<EuiBreadcrumbs
responsive={{
Expand All @@ -258,9 +258,13 @@ export const BreadcrumbsExample = {
emphasis or indicate state like <EuiCode>{"'danger'"}</EuiCode> for
an error. However, use caution not to use color alone.
</p>
<p>
Please also note that link colors cannot be overriden for{' '}
<EuiCode>type={'"application"'}</EuiCode> breadcrumbs.
</p>
</>
),
props: breadcrumpProps,
props,
demo: <Color />,
source: [
{
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/breadcrumbs/playground.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { EuiBreadcrumbs } from '../../../../src/components/breadcrumbs';
import { EuiBreadcrumbs } from '../../../../src/components';
import {
propUtilityForPlayground,
generateCustomProps,
Expand Down
4 changes: 2 additions & 2 deletions src-docs/src/views/breadcrumbs/props.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import {
EuiBreadcrumbResponsiveMaxCount,
} from '../../../../src/components/breadcrumbs';

export const BreadcrumbProps: FunctionComponent<EuiBreadcrumb> = () => <div />;

export const BreadcrumbResponsiveMaxCount: FunctionComponent<EuiBreadcrumbResponsiveMaxCount> = () => (
<div />
);

export const BreadcrumbProps: FunctionComponent<EuiBreadcrumb> = () => <div />;
Loading