Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Add branchUser, desktop and sessionViewer icons #5740

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Mar 22, 2022

Summary

This PR introduces 3 new Icons that were added as part of a new Security plugin that is going to be added as part of the 8.2 release: SessionView. Session View is meant to provide a visualization into what is going on in a particular Linux environment where the agent is running. It looks like a terminal emulator; however, it is a tool for introspecting process activity and understanding user and service behaviour in your Linux servers and infrastructure. It is a time-ordered series of process executions displayed in a tree over time:

Screenshots

Grid

image

Use cases

Session Viewer UI

  • branchUser icon: When a fork of a Linux process occurs due to a user command execution. Named as branchUser as extension of the already existing branch icon
  • desktop icon: Used to indicate a Session being displayed on a monitor. Named as desktop to make available for general usage.

image

Session View in a general context in Kibana -> Security:

image

The Open in Session View button

  • sessionViewer icon - Used to indicate that the session will be opened in Session Viewer, created a new Icon instead of using the console to enforce that it's a terminal Session Viewer

image

image

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@opauloh opauloh requested a review from cchaos March 22, 2022 18:43
@opauloh opauloh requested a review from codearos March 22, 2022 18:49
@opauloh opauloh marked this pull request as draft March 22, 2022 19:03
@opauloh
Copy link
Contributor Author

opauloh commented Mar 22, 2022

Converted to draft to make some adjustments on the desktop icon to make it fully 1px thick lines

@cchaos
Copy link
Contributor

cchaos commented Mar 22, 2022

FYI EUI team, I'm chatting with @opauloh and @ph directly to see if we can get these icons more pixel aligned and compressed.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5740/

@opauloh opauloh marked this pull request as ready for review March 23, 2022 14:43
@opauloh
Copy link
Contributor Author

opauloh commented Mar 23, 2022

@cchaos added optimizations on all Icons (flattening/compressing) and fixed Icons alignment

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Code looks great! Just one quick changelog comment while we wait for the PR build.

upcoming_changelogs/5740.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5740/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5740/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Checked in dark mode, at 1x and ensured they scale properly. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants