Added a Figma specific PR checklist item #5718
Conversation
cchaos
requested review from
chandlerprall,
elizabetdev,
thompsongl,
cee-chen,
breehall and
1Copenut
|
No objections, but any chance we can get a quick TL;DR or rundown of what developers (say, ones who have never opened Figma before 🙈) should be doing for this checklist? Should we be attempting to L2Figma or should we be tagging Caroline or Elizabet in to handle that checkbox?... Also does EuiDataGrid have a figma component? Asking for a friend (it's me, I'm my own friend) edit: I leveled up by actually opening the figma link (fun fact, did you know firefox reports figma as a script slowing down the entire page) and saw that yes, yes we do have a data grid figma component hahaa |
|
Lol. Yes @constancecchen the Figma community page is SUPER slow because for some reason Figma is trying to render all the pages in that box instead of just the one selected, and well, because our library is HUGE. It's also going to be a learning curve for our productivity workflow. No, I don't really expect engineers to be updating the Figma side, but certainly to be considering the necessity of and figuring out who might be best to pair with to implement that side. For instance, if the originating issue came from a designer or other team, it might be asking for support from that designer or a designer from that team to update Figma side. If those are unknown, then tagging either @miukimiu or myself is a fair approach. I just want to make sure we're mindful and not just crossing it off every time because it was an engineer's PR. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5718/ |
|
Thank you all for approving! We can also continue discuss this some more in our weekly on Tuesday. |
The UX org leads have been brainstorming ideas to try to keep the Figma library from falling out of relevance. We know that the EUI members can't be everywhere (and honestly we hardly use the Figma library ourselves), but one thing we can be more proactive on is ensuring that we consider the Figma side when we make visual updates to the components.
As per usual checklist tasks, you can just cross this one off if it doesn't apply to your PR.
We also know that this will more than likely fall on our designer team members so please be mindful of the extra workload/communication of design changes.
If it's not likely something to be tackled within the timeframe of the PR, there is now a Figma specific repo where we can add issues: https://github.com/elastic/eui-figma/issues