[EuiGlobalStyles] Omit global and reset styles when using legacy theme #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
reviewed
Dec 15, 2021
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5473/ |
thompsongl
changed the title
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5473/ |
cchaos
approved these changes
Dec 15, 2021
cee-chen
approved these changes
Dec 15, 2021
Co-authored-by: Caroline Horn <[email protected]>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5473/ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes
EuiGlobalStylestheme-aware so that global and reset styles are not added when using the legacy theme.Decided to do this in the component rather than in the docs because as we move forward, we'll need to account for future and custom themes potentially having different global styles. For now, we can simply use
isLegacyThemeas the flag.Checklist