-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiIcon] Add magnifyWithExclamation
icon
#5455
[EuiIcon] Add magnifyWithExclamation
icon
#5455
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5455/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5455/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5455/ |
@cchaos I improved the design and the exclamation mark is no longer 100% similar to the one in Non-retina displaysI tested in Safari and Firefox (low resolution) and these are the results comparing with the previous version: Retina displaysOn retina displays I think the exclamation mark now looks better: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Looks much crisper!
Looks like you need to update the snapshot again.
Preview documentation changes for this PR: https://eui.elastic.co/pr_5455/ |
Summary
This PR adds a
magnifyWithExclamation
glyph to EuiIcon and closes #5274.Design
alert
icon. Initially, it was using the same, but it was not looking good on non-retina displays and for this reason, it was enhanced.alert
icon the exclamation mark is centered in the circle.Dark and light themes
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/main/wiki/documentation-guidelines.md#adding-playground-toggles)**[ ] Added documentation[ ] Checked Code Sandbox works for any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes