Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiRange] Remove tick label scrollbars in Safari #5427

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Dec 1, 2021

Summary

Fixes #5425 by adding overflow-y: hidden; to the tick label elements.

Note that this bug only affects Safari, and is really only noticeable when system scrollbars are configured to show "Always" (System Preferences > General > Show scrollbars)

overflow: hidden; was not used because we override overflow-x in the case of custom labels.
Pink: Desired label truncation
Orange: Desired label overflow
Screen Shot 2021-12-01 at 10 06 20 AM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox

- [ ] Props have proper autodocs and playground toggles
- [ ] Added documentation
- [ ] Checked Code Sandbox works for any docs examples
- [ ] Added or updated jest and cypress tests

  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5427/

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this is fixed for me on Safari with scrollbars set to "Always"! 🎉

@cchaos cchaos requested a review from elizabetdev December 1, 2021 17:13
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5427/

Copy link
Contributor

@elizabetdev elizabetdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thompsongl! I tested in Safari with System Preferences > General > Show scrollbars and LGTM! 🎉

I also tested in Firefox and Chrome.

@thompsongl thompsongl merged commit de40352 into elastic:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiRange] Ticks have scrollbars on the side
4 participants