[Tech debt/docs] Unit test updates #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no need to specify `yarn run` - no need for an extra `--` before passing in more flags
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5075/ |
- not to use sinon vs standard expect() syntax - to have spacing that will better match what prettier will lint to
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5075/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm writing unit tests for datagrid child components, and I like to run with the
--coverageflag when writing tests to help me catch any branches or uncovered lines I may have forgotten. I noticed my coverage reports weren't what I expected, and updated ourjest/config.jsonaccordingly to account for most/all of our files now being.ts/.tsx.I also noticed from our wiki docs that the commands we run have some outdated syntax that no longer apply - the
runcommand isn't necessary with yarn, nor is the--delineator. I've been runningyarn test-unit data_grid -u --coverage --watchlocally with no issues.Checklist
N/A, dev/documentation only changes