-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[euiHeaderAffordForFixed] Don't apply offset styles to EuiOverlayMask or EuiFlyout when EuiDataGrid is full screen #5054
[euiHeaderAffordForFixed] Don't apply offset styles to EuiOverlayMask or EuiFlyout when EuiDataGrid is full screen #5054
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5054/ |
💟 Thanks for the PR @MichaelMarcialis !! I'm wondering if we should also specifically add in some examples to our docs that trigger flyouts and modals so we might better keep track of those things. Would you be up for doing that? |
@cchaos: Sure, I can see about adding an example of an |
You can build it directly into this PR. It'll also make it easier to test this PR to have an example to look at. How about just updating the action items in the first/initial example which has kind of become our Kitchen sink of sorts. If you need help with content, just shout. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5054/ |
…ull-screen-fix # Conflicts: # CHANGELOG.md
Preview documentation changes for this PR: https://eui.elastic.co/pr_5054/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work. Thank you for taking this so quickly. I left some small suggestions, but I think it's OK to merge after addressing them.
@chandlerprall @thompsongl I'd like to backport this one as a patch because it's causing breaks in Kibana. Might be a good opportunity to show @breehall and @constancecchen how we do those. I'll make an issue for an upcoming patch.
I think this one is worth testing a local build with Kibana to make sure this solves the problem. I'm going to spin that up so it'll be a couple hours before I review 😬 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5054/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Looks like it's a z-indexing issue with the banner showing above the data grid. I'll merge this in and take a peek at that after, as that's likely on the Kibana side. |
Summary
It was recently noticed in Kibana that
EuiOverlayMask
andEuiFlyout
components were still accounting for the presence ofEuiHeader
components, even whenEuiDataGrid
is in full screen mode. This was due to the EUI mixineuiHeaderAffordForFixed
.This PR changes the mixin to now avoid applying these offset styles (
top
,height
) whenEuiDataGrid
is in full screen (via the:not(.euiDataGrid__restrictBody)
selector).Additionally, while adding examples of
EuiModal
andEuiFlyout
being triggered from within anEuiDataGrid
(per @cchaos 's suggestion), it was discovered that theEuiModal
andEuiFlyout
components had az-index
that caused them to appear belowEuiDataGrid
components when in full screen mode (outside Kibana). A fix for this is also included in this PR (thanks to @cchaos for the direction).Closes elastic/kibana#108681.
Closes elastic/kibana#108896.
CCing @snide, @ryankeairns, @XavierM.
Before:
After:
Checklist
[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes