[CSS-in-JS] useEuiTheme & withEuiTheme refactor #4594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4594/ |
|
jenkins test this
|
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4594/ |
cchaos
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
👍 LGTM! Thanks for making this change. I think it's also easier this way if they ever just need to grab the current color mode. Instead of everything.
I posted a commit that just updated the doc section wording a bit. Feel free to edit if I didn't use the right language.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4594/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
useEuiThemefrom an array ([ theme, colorMode, modifications ]) to an object of shape{ euiTheme, colorMode, modifications }withEuiThemeto clarify wrapped component props and HOC props, allowing for IDE autocomplete support for theme variables.### Checklist