Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiResizableContainer] Allow dynamic direction #4557

Merged
merged 9 commits into from
Feb 24, 2021
Merged

[EuiResizableContainer] Allow dynamic direction #4557

merged 9 commits into from
Feb 24, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Feb 19, 2021 •
edited
Loading

Summary

Closes #4555 by allowing for changing the direction prop and preventing state errors during panel re-registry.

See to-be-reverted docs "Simple" example for a demo.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile

  • Checked in Chrome, Safari, Edge, and Firefox

- [ ] Props have proper autodocs and playground toggles
- [ ] Added documentation

- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/

@thompsongl
Copy link
Contributor Author

jenkins test this

Error: Timed out waiting for: http-get://localhost:9999

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/

@cchaos
Copy link
Contributor

cchaos commented Feb 22, 2021

See to-be-reverted docs "Simple" example for a demo.

I'd actually love to keep an example in the docs for others to use and to keep track to ensure it continues to behave properly.

@thompsongl
Copy link
Contributor Author

I'd actually love to keep an example in the docs for others to use and to keep track to ensure it continues to behave properly.

Keep the modifications to the current example, or create a new section?

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/

@cchaos
Copy link
Contributor

cchaos commented Feb 22, 2021

Keep the modifications to the current example, or create a new section?

Either, or, just make it clear somwhere that that example exemplifies this behavior.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/

cchaos
cchaos approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks! In a follow up, it'd be great to also maintain the collapsed state when shifting between layouts.

src-docs/src/views/resizable_container/resizable_panel_collapsible_responsive.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/

chandlerprall
chandlerprall approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; Tested locally & new example in deployed docs

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4557/

@thompsongl thompsongl merged commit 48ddc80 into elastic:master Feb 24, 2021
@chandlerprall chandlerprall mentioned this pull request Mar 5, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@thompsongl thompsongl mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiResizableContainer] Allow for dynamic prop changes
4 participants
@thompsongl @kibanamachine @cchaos @chandlerprall