Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuggest] Prevents popover to open when empty array is passed into suggestions #4349

Merged
merged 5 commits into from
Dec 9, 2020
Merged

[EuiSuggest] Prevents popover to open when empty array is passed into suggestions #4349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b89df2e
Prevented popover to open when empty array is passed into suggestions…
elizabetdev Dec 4, 2020
2d49977
Adding CL
elizabetdev Dec 4, 2020
715d2e0
Update src/components/suggest/suggest_input.tsx
elizabetdev Dec 9, 2020
d5905b3
Update CHANGELOG.md
elizabetdev Dec 9, 2020
62212cc
Merge remote-tracking branch 'upstream/master' into fix-suggest-panel…
elizabetdev Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Fixed `EuiErrorBoundary` error message not showing in non-Chromium browsers ([#4324](https://github.com/elastic/eui/pull/4324))
- Fixed `EuiToolTip` closing during initial positioning period ([#4327](https://github.com/elastic/eui/pull/4327))
- Added `!default` to SASS variables of `EuiCollapsibleNav` ([#4335](https://github.com/elastic/eui/pull/4335))
- Prevented `EuiSuggest` popover to open when an empty array is passed into `suggestions` prop ([#4349](https://github.com/elastic/eui/pull/4349))
elizabetdev marked this conversation as resolved.
Show resolved Hide resolved

**Theme: Amsterdam**

Expand Down
2 changes: 1 addition & 1 deletion src/components/suggest/suggest_input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export const EuiSuggestInput: FunctionComponent<EuiSuggestInputProps> = (
<EuiInputPopover
className={classes}
input={customInput}
isOpen={isPopoverOpen}
isOpen={suggestions.length > 0 && isPopoverOpen}
elizabetdev marked this conversation as resolved.
Show resolved Hide resolved
panelPaddingSize="none"
fullWidth
closePopover={closePopover}>
Expand Down