Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[EuiPopover] Default to ownFocus (#4228)" #4311

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Revert "[EuiPopover] Default to ownFocus (#4228)" #4311

merged 2 commits into from
Nov 25, 2020

Conversation

chandlerprall
Copy link
Contributor

Summary

This reverts commit da291a1.

While we want to default ownFocus=true, the Kibana upgrade PR flagged two issues this causes:

I've built EUI with this change and confirmed it resolves the issues in Kibana

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4311/

thompsongl
thompsongl approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; confirmed reversal of default behavior.

@chandlerprall chandlerprall merged commit 01aae31 into elastic:master Nov 25, 2020
@chandlerprall chandlerprall deleted the revert-4228 branch November 25, 2020 16:59
@chandlerprall chandlerprall mentioned this pull request Nov 25, 2020
Closed
@myasonik myasonik mentioned this pull request Feb 19, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @kibanamachine @thompsongl