-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiFilterGroup] and [EuiFilterButton] Fix styling for Amsterdam #4151
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_4151/ |
Looks so good! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cchaos Looks great, the only thing I'm finding now with the latest changes in is this:
Thanks @andreadelrio ! I was hoping no one would catch that. 😆 It's an artifact from the fact that our form borders use a transparency and when certain filter buttons are grouped together, I pull them closer together. I'll see if there's a quick fix, but we might live with that for a bit. |
Yeah, I can't find an easy solution and I also noticed this is only happening once the buttons stack (mobile view) so I think it will really be a rare occurrence. Would love to punt on that one for another time. |
Alright, LGTM then! 🎉 |
Fixes Amsterdam style of filter buttons to match form inputs
After 4 hours of struggling with this thing, I was finally able to get it to work with the rounded corners and minimal style overrides.
Some before and afters
Checklist
[ ] Props have proper autodocs[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes