Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFilterGroup] and [EuiFilterButton] Fix styling for Amsterdam #4151

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Oct 16, 2020

Fixes Amsterdam style of filter buttons to match form inputs

After 4 hours of struggling with this thing, I was finally able to get it to work with the rounded corners and minimal style overrides.

Some before and afters

Screen Shot 2020-10-16 at 15 44 12 PM

Screen Shot 2020-10-16 at 15 45 28 PM

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4151/

@johnbarrierwilson
Copy link
Member

Looks so good! 🎉

Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cchaos Looks great, the only thing I'm finding now with the latest changes in is this:

Group 5

@cchaos
Copy link
Contributor Author

cchaos commented Oct 19, 2020

Thanks @andreadelrio ! I was hoping no one would catch that. 😆 It's an artifact from the fact that our form borders use a transparency and when certain filter buttons are grouped together, I pull them closer together. I'll see if there's a quick fix, but we might live with that for a bit.

@cchaos
Copy link
Contributor Author

cchaos commented Oct 19, 2020

Yeah, I can't find an easy solution and I also noticed this is only happening once the buttons stack (mobile view) so I think it will really be a rare occurrence. Would love to punt on that one for another time.

@andreadelrio
Copy link
Contributor

Yeah, I can't find an easy solution and I also noticed this is only happening once the buttons stack (mobile view) so I think it will really be a rare occurrence. Would love to punt on that one for another time.

Alright, LGTM then! 🎉

@cchaos cchaos merged commit 028aec0 into elastic:master Oct 19, 2020
@cchaos cchaos deleted the ams/filter_group branch October 19, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants