Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] Fix popover returning focus to correct element #4071

Merged
merged 13 commits into from
Nov 4, 2020
Merged

[EuiPopover] Fix popover returning focus to correct element #4071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cf88a0c
Move onclickoutside / onescape handling to focus-lock lib itself
chandlerprall Sep 10, 2020
7c97d64
Get popover focus return functioning
chandlerprall Sep 23, 2020
a587534
Fix lint issues & snapshots, re-enable clickOutsideDisables prop for …
chandlerprall Sep 24, 2020
bc5b666
fix popover re-toggling when clicking its anchor
chandlerprall Sep 28, 2020
172af2d
Re-enable popover outside click and escape key detection when ownFocu…
chandlerprall Sep 28, 2020
5bc02fb
Only call popover's closePopover callback when it is open
chandlerprall Sep 29, 2020
374c41b
Don't scroll back to a popover anchor when the popover closes
chandlerprall Oct 1, 2020
6d6e1be
Address unintentional changes to flyouts & color picker
chandlerprall Oct 29, 2020
baebfb1
Merge branch 'master' into bug/4003-popover-re-focus
chandlerprall Nov 4, 2020
206c7b0
changelog
chandlerprall Nov 4, 2020
ae58e17
Merge branch 'master' into bug/4003-popover-re-focus
chandlerprall Nov 4, 2020
a68536b
revert changes to popover example, which had been made to augment tes…
chandlerprall Nov 4, 2020
3e99a23
Fix flyout's snapshot tests
chandlerprall Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

**Bug fixes**

- Fixed focus trap + `EuiPopover` bug which prevented the anchor from receiving focus when the popover closes ([#4071](https://github.com/elastic/eui/pull/4071))
- Fixed focus trap error & performance impact when one focus trap is deactivated and another becomes enabled ([#4071](https://github.com/elastic/eui/pull/4071))
- Fixed a condition in `EuiInMemoryTable` to avoid mistaken assignment of `sortName` ([#4138](https://github.com/elastic/eui/pull/4138))

## [`30.2.0`](https://github.com/elastic/eui/tree/v30.2.0)
Expand Down
1 change: 0 additions & 1 deletion src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ exports[`EuiInMemoryTable behavior pagination 1`] = `
panelPaddingSize="none"
>
<EuiOutsideClickDetector
isDisabled={true}
onOutsideClick={[Function]}
>
<div
Expand Down
Loading