Add controlled pagination props to EuiInMemoryTable #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryTable's pagination
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4038/ |
thompsongl
approved these changes
Sep 16, 2020
src-docs/src/views/tables/in_memory/in_memory_controlled_pagination_section.js
Outdated
Show resolved
Hide resolved
…ation_section.js Co-authored-by: Greg Thompson <[email protected]>
|
network issue, jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4038/ |
chandlerprall
deleted the
feature/3982-in-memory-table-external-pagination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3982
Added
pageSizeandpageIndexcontrolled values to EuiInMemoryTable'spaginationprop, as well as a new example & documentation, plus unit tests.I opted to not make the TS types more complex, but did think about e.g. forcing
initialPageSize: neverwhenpageSizeis present. Did not seem worth the effort, instead calling out the interaction in the props' documentation.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked Code Sandbox works for the any docs examples